-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hub: add image library section #21485
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
db2f7d9
to
bbdc99e
Compare
79e1e17
to
169f2f0
Compare
169f2f0
to
848d48f
Compare
Signed-off-by: Craig <[email protected]>
848d48f
to
4367135
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good!
demos provide a hands-on way to explore AI tools and frameworks, making it | ||
easier to understand how they can be integrated into real-world applications. | ||
- Models: Pre-trained AI models for tasks like text generation, | ||
natural language processing (NLP), and conversational AI. These models |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deals with the vale nag
natural language processing (NLP), and conversational AI. These models | |
Natural Language Processing (NLP), and conversational AI. These models |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dvdksn Fixing it. But, is that a vale limitation, or do we consider all terms to be proper nouns if they have an acronym?
For example in this particular case, Wikipedia considers NLP not a proper noun https://en.wikipedia.org/wiki/Natural_language_processing
And Microsoft style guide says don't capitalize unless a proper noun, https://learn.microsoft.com/en-us/style-guide/acronyms#lowercase-the-spelled-out-term
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's how our rule for these acronyms is configured:
docs/_vale/Docker/Acronyms.yml
Line 8 in aae93f6
second: '(?:\b[A-Z][a-z]+ )+\(([A-Z]{2,5})\)' |
We only consider an acronym spelled out if it's preceded by a Proper Noun. It doesn't actually check that that the acronym and the proper nouns are the same. (In other words, Some Random Word (FOO) would be considered valid by this vale rule.)
I don't think there's a way to make this rule smarter with the built-in vale styles. But we might be able to write a tengo script. I can take a quick look. Otherwise, I think our alternatives are:
- Use proper nouns when spelling out an acronym anyway (I don't mind this rule)
- Don't check for unexpanded acronyms at all
- Manually ignore this rule:
<!-- vale Docker.Acronyms = NO -->
Signed-off-by: Craig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
https://deploy-preview-21485--docsdocker.netlify.app/docker-hub/
https://deploy-preview-21485--docsdocker.netlify.app/docker-hub/image-library/
https://deploy-preview-21485--docsdocker.netlify.app/docker-hub/image-library/search/
https://deploy-preview-21485--docsdocker.netlify.app/docker-hub/image-library/catalogs/
https://deploy-preview-21485--docsdocker.netlify.app/docker-hub/image-library/trusted-content/
https://deploy-preview-21485--docsdocker.netlify.app/docker-hub/repos/manage/trusted-content/
Related issues or tickets
ENGDOCS-2352
Reviews